Review Request 123312: I have added KMessageBox::warningYesNoCancel if someone has unsaved changes left when closing the application.

[Sune Vuorela]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123312/#review78868
-----------------------------------------------------------


I'm not a cantor developer, so not up for acually giving a shipit. I do have  a couple of minor comments here


src/cantor.h (line 98)
<https://git.reviewboard.kde.org/r/123312/#comment53930>

    bool warnModified()  makes me think it is returns true if it succesfully warned. Isn't it more like a bool reallyQuit() or reallyClose() ?



src/cantor.cpp (line 344)
<https://git.reviewboard.kde.org/r/123312/#comment53929>

    SHouldn't you check the return value and act accordingly?



src/cantor.cpp (line 391)
<https://git.reviewboard.kde.org/r/123312/#comment53931>

    shouldn't there be a else {
        KParts::MainWindow::closeEvent(event); 
    }
    
    here ?


- Sune Vuorela


On April 9, 2015, 7:22 p.m., Garvit Khatri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123312/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 7:22 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=324581
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=324581
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Warning about unsaved data in cantor
> 
> 
> Diffs
> -----
> 
>   src/cantor.h c703f5d 
>   src/cantor.cpp 16eb7d9 
> 
> Diff: https://git.reviewboard.kde.org/r/123312/diff/
> 
> 
> Testing
> -------
> 
> I have tested it on KF5.
> 
> 
> Thanks,
> 
> Garvit Khatri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150412/645dcbb5/attachment-0001.html>