Review Request 120292: Fix build error of analitza on OSX

Marko Käning mk-lists at email.de
Wed Sep 24 23:49:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120292/
-----------------------------------------------------------

(Updated Sept. 24, 2014, 11:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Aleix Pol Gonzalez.


Repository: analitza


Description
-------

Insert a cast in free() call on OSX in order to avoid this:
```
Building CXX object analitzaplot/CMakeFiles/AnalitzaPlot.dir/private/utils/marchingcubes.cpp.o
[ 65%] /Users/marko/WC/KDECI-builds/analitza/calgebra/main.cpp:157:3: error: no matching function for call to 'free'
               free(he->line);
               ^~~~
/usr/include/stdlib.h:143:7: note: candidate function not viable: no known conversion from 'const char *' to 'void *' for 1st argument; take the address of the argument with &
void     free(void *);
        ^
Building CXX object analitzaplot/CMakeFiles/AnalitzaPlot.dir/private/abstractplotitem.cpp.o
1 error generated.
make[2]: *** [calgebra/CMakeFiles/calgebra.dir/main.cpp.o] Error 1
make[1]: *** [calgebra/CMakeFiles/calgebra.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
```


Diffs
-----

  calgebra/main.cpp ddb5ab0 

Diff: https://git.reviewboard.kde.org/r/120292/diff/


Testing
-------

+ analitza builds fine w/o error

+ Wondering though, why HAVE_FREE_HISTORY_ENTRY is undefined...
 (Does readline get properly detected on OSX?)


Thanks,

Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140924/bfd5ca7a/attachment.html>


More information about the kde-edu mailing list