Review Request 120275: Refactor #2 in parley
Inge Wallin
inge at lysator.liu.se
Thu Sep 18 22:42:58 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120275/
-----------------------------------------------------------
Review request for KDE Edu, Amarvir Singh, Andreas Xavier, and Jeremy Whiting.
Repository: parley
Description
-------
This is the continuation of my last refactoring of parley which would lead to a better separation of model and view. This one contains:
- Moving of views in src/vocabulary/ to src/collection/ and src/editor/
- Removing of the src/export/ directory (there were only 3 files in there)
- Removing of the Editor namespace outside the actual editor.
There should be no functional changes and only moving of files and some followup changes like the CMakelists.txt file.
After this change I will start to introduce real code changes which may have to be reviewed in more detail.
Diffs
-----
src/CMakeLists.txt aea7fe3
src/collection/containermimedata.h 6ce4bba
src/collection/containermimedata.cpp 9a81aa0
src/collection/containermodel.h a194f88
src/collection/containermodel.cpp 49bbe86
src/collection/containerview.h PRE-CREATION
src/editor/vocabularycolumnsdialog.cpp PRE-CREATION
src/editor/vocabularydelegate.h PRE-CREATION
src/editor/vocabularydelegate.cpp PRE-CREATION
src/editor/vocabularyheaderview.h PRE-CREATION
src/editor/vocabularyheaderview.cpp PRE-CREATION
src/editor/vocabularyview.h PRE-CREATION
src/editor/vocabularyview.cpp PRE-CREATION
src/editor/wordtypeview.h PRE-CREATION
src/collection/containerview.cpp PRE-CREATION
src/collection/entryfilter.h 7122ef6
src/collection/entryfilter.cpp 614981f
src/collection/lessonmodel.h 8f5ffa0
src/collection/lessonmodel.cpp 72335c4
src/collection/readonlycontainermodel.h bd19167
src/collection/readonlycontainermodel.cpp e2ea6f5
src/collection/vocabularyfilter.h PRE-CREATION
src/collection/vocabularyfilter.cpp PRE-CREATION
src/collection/vocabularymimedata.h 99b367c
src/collection/vocabularymimedata.cpp d071b1f
src/collection/vocabularymodel.h d77ce9e
src/collection/vocabularymodel.cpp 158db0d
src/collection/wordclassmodel.h d7955ef
src/collection/wordclassmodel.cpp 5d56aaa
src/editor/editor.h 546c9a5
src/editor/editor.cpp 68e5bed
src/editor/latexwidget.h f1aed27
src/editor/latexwidget.cpp dbe6251
src/editor/lessonview.h PRE-CREATION
src/editor/lessonview.cpp PRE-CREATION
src/editor/summarywordwidget.h a9c3e75
src/editor/summarywordwidget.cpp f3d67f7
src/editor/vocabularycolumnsdialog.h PRE-CREATION
src/vocabulary/vocabularyview.cpp 8bb7f7e
src/vocabulary/wordtypeview.h dbb26ea
src/vocabulary/wordtypeview.cpp 5d9edbd
src/vocabulary/vocabularyfilter.h b5655fe
src/vocabulary/vocabularyfilter.cpp 37ab1e6
src/vocabulary/vocabularyheaderview.h 7e6e4e5
src/vocabulary/vocabularyheaderview.cpp 0b2572e
src/vocabulary/vocabularyview.h 0fdd771
src/vocabulary/lessonview.h b2a2476
src/vocabulary/lessonview.cpp af3a36d
src/vocabulary/vocabularycolumnsdialog.h 376c103
src/vocabulary/vocabularycolumnsdialog.cpp d8fd5f7
src/vocabulary/vocabularydelegate.h be17eaa
src/vocabulary/vocabularydelegate.cpp 7c4b1b6
src/vocabulary/containerview.h 379dd13
src/vocabulary/containerview.cpp 42e6c1c
src/vocabulary/leitnerview.cpp 1d50686
src/parleymainwindow.h 87361d7
src/scripts/scripting/parley.cpp 10b0c31
src/statistics/lessonstatistics.h 42597c6
src/statistics/lessonstatistics.cpp 64b5f18
src/statistics/statisticsmainwindow.cpp cbed13d
src/statistics/statisticsmodel.h 19b2115
src/export/exportdialog.h 2c84053
src/export/exportdialog.cpp 9b4319f
src/export/exportdialog.ui 4ac26bf
src/exportdialog.h PRE-CREATION
src/exportdialog.cpp PRE-CREATION
src/exportdialog.ui PRE-CREATION
src/parleydocument.cpp ee4fc93
src/editor/wordtypeview.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/120275/diff/
Testing
-------
Lots of checks after each move.
Thanks,
Inge Wallin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140918/0cbfd474/attachment.html>
More information about the kde-edu
mailing list