Review Request 120238: [huge patch] reformat whole code base of Kalzium

Etienne Rebetez etienne.rebetez at gmail.com
Wed Sep 17 20:58:50 UTC 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120238/#review66786
-----------------------------------------------------------

Ship it!


Wow. Thanks a lot!
Looks fine and it worked for me. The code realy needed some cleanup :-)

- Etienne Rebetez


On Sept. 17, 2014, 2:42 vorm., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120238/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 2:42 vorm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Across the project there are many coding styles with lots of different indentation patterns. There are three different tabs to space conversions (1:2, 1:4, 1:8), even mixed within individual files. This makes the code unnecessarily hard to read and to edit.
> 
> In the hope that I do not offend anybody: unify code style.
> 
> Roughly apply the style from kdelibs:
> 
> * get rid of all tabs
> * indentation is four spaces
> * unify includes and include guards
> * less blank lines
> * one space after "if", "for", etc.
> * no space after cast
> * prefix operators ("++", "--") instead of postfix where applicable
> * pointers: preferably single space before "*" (same for "&")
> * opening curly braces on same line except for implementations
> * no whitespace after opening parenthesis "(" or before closing ones ")"
> * no single line "if", "for", "else", etc. (always curly braces)
> * indent "case" to same level as corresponding "switch"
> * at least in some files adjust line wraps to a limit of 100 chars
> * exactly one newline at EOF
> 
> Also some formatting to copyright statements (I hope this is legally ok)
> 
> Additionally:
> * fix some spelling errors
> * constify& some foreach loops (suggested by krazy2)
> * replace some single char strings with chars (suggested by krazy2)
> 
> This whole patch fixes between 15 and 20 krazy2 warnings.
> 
> 
> Diffs
> -----
> 
>   src/tablesdialog.cpp 271d37c 
>   src/tools/moleculeview.h f58d69f 
>   src/tools/moleculeview.cpp c8af4f3 
>   src/tools/moleculewidgetplugin.h 1b2b392 
>   src/tools/obconverter.h bb296b6 
>   src/tools/obconverter.cpp 4f32302 
>   src/unitsettingsdialog.h 5e6d5cf 
>   src/unitsettingsdialog.cpp 5492860 
>   compoundviewer/kalziumglpart.h bb1fdc4 
>   compoundviewer/kalziumglpart.cpp 749520d 
>   src/spectrumwidget.cpp db08cf6 
>   src/tableinfowidget.h 01a93b1 
>   src/tableinfowidget.cpp d9ed673 
>   src/tablesdialog.h f6d4678 
>   plasmoid/applet/psePlasmoid/Periodictable.h 5ec255e 
>   plasmoid/applet/psePlasmoid/Periodictable.cpp b9e0519 
>   plasmoid/engine/kalzium_engine.cpp 301ab5d 
>   qml/Cell2.qml 92969ae 
>   qml/CenterInformation.qml ca6c46c 
>   src/CMakeOCamlInstructions.cmake aa2b21a 
>   src/calculator/calculator.h 2d3728f 
>   src/calculator/calculator.cpp 96044a5 
>   src/calculator/concCalculator.h 1e10fba 
>   src/calculator/concCalculator.cpp 268077f 
>   src/calculator/gasCalculator.h 2bba31a 
>   src/calculator/gasCalculator.cpp 645c34f 
>   src/calculator/nuclearCalculator.h 4b4882c 
>   src/calculator/nuclearCalculator.cpp 1df965e 
>   src/calculator/titrationCalculator.h 51a8d69 
>   src/calculator/titrationCalculator.cpp 5738644 
>   src/detailedQmlView.h 738b368 
>   src/detailedQmlView.cpp d55fc53 
>   src/detailedgraphicaloverview.h ba13a7b 
>   src/detailedgraphicaloverview.cpp d9c3173 
>   src/detailinfodlg.h 64c2a8c 
>   src/detailinfodlg.cpp f3cdce3 
>   src/elementdataviewer.h eb8c776 
>   src/elementdataviewer.cpp ccb1195 
>   src/eqchemview.h 1872a11 
>   src/eqchemview.cpp 0e36a82 
>   src/exportdialog.h e0b95b2 
>   src/exportdialog.cpp aa2e789 
>   src/gradientwidget_impl.h 4f27186 
>   src/gradientwidget_impl.cpp f33695f 
>   src/isotopetable/informationitem.h a247f3e 
>   src/isotopetable/informationitem.cpp bb14ec5 
>   src/isotopetable/isotopeguideview.h 1557924 
>   src/isotopetable/isotopeguideview.cpp b833150 
>   src/isotopetable/isotopeitem.h 39287c1 
>   src/isotopetable/isotopeitem.cpp 5b416ab 
>   src/isotopetable/isotopescene.h e3a226c 
>   src/isotopetable/isotopescene.cpp 8bbfdbd 
>   src/isotopetable/isotopetabledialog.h 385b77b 
>   src/isotopetable/isotopetabledialog.cpp 1f6f544 
>   src/isotopetable/isotopeview.h c16f99a 
>   src/isotopetable/isotopeview.cpp 47c552d 
>   src/kalzium.h 5d315e8 
>   src/kalzium.cpp 265b38b 
>   src/kalziumdataobject.h 98cae27 
>   src/kalziumdataobject.cpp 931f3a3 
>   src/kalziumelementproperty.h 2c24221 
>   src/kalziumelementproperty.cpp 9062f6f 
>   src/kalziumgradienttype.h e68eec5 
>   src/kalziumgradienttype.cpp bfcbbd5 
>   src/kalziumnumerationtype.h 61f6658 
>   src/kalziumnumerationtype.cpp 78edd1d 
>   src/kalziumschemetype.h 786641d 
>   src/kalziumschemetype.cpp 65f6a91 
>   src/kalziumunitcombobox.h fd34ad6 
>   src/kalziumunitcombobox.cpp ed4e189 
>   src/kalziumutils.h 99e4d97 
>   src/kalziumutils.cpp b35f729 
>   src/kdeeduglossary.h 5e0071c 
>   src/kdeeduglossary.cpp 84fe531 
>   src/legendwidget.h 9e601d6 
>   src/legendwidget.cpp 521204b 
>   src/main.cpp 62c0166 
>   src/molcalcwidget.h 84260c5 
>   src/molcalcwidget.cpp 907cd6a 
>   src/orbitswidget.h 4bc4dee 
>   src/orbitswidget.cpp 373e7c8 
>   src/psetable/elementitem.h b805153 
>   src/psetable/elementitem.cpp db9b199 
>   src/psetable/numerationitem.h 04b9289 
>   src/psetable/numerationitem.cpp 9ff1fc5 
>   src/psetable/periodictablescene.h c429551 
>   src/psetable/periodictablescene.cpp 8499bb0 
>   src/psetable/periodictablestates.h a3d77b7 
>   src/psetable/periodictablestates.cpp 22df5d8 
>   src/psetable/periodictableview.h 4460626 
>   src/psetable/periodictableview.cpp 2dc37f0 
>   src/psetable/statemachine.h 7f3a9c0 
>   src/psetable/statemachine.cpp 20b76a7 
>   src/rsdialog.h d67ae3c 
>   src/rsdialog.cpp d784968 
>   src/search.h bf0c8b9 
>   src/search.cpp aacad93 
>   src/searchwidget.h 5dddcd3 
>   src/searchwidget.cpp a4db6d8 
>   src/solver/README cf7a78f 
>   src/solver/calc.ml 745f7c1 
>   src/solver/chem.ml 2e0dd96 
>   src/solver/chemset.ml d813684 
>   src/solver/datastruct.ml 541ed8c 
>   src/solver/lexer.ml e82d680 
>   src/solver/lexer.mll a6a4ab4 
>   src/solver/main.c d8e5e1b 
>   src/solver/main.ml f940f1d 
>   src/solver/modwrap.c 84395a3 
>   src/solver/parser.mly 41d91f3 
>   src/spectrumviewimpl.h bb31de2 
>   src/spectrumviewimpl.cpp 03b7fbd 
>   src/spectrumwidget.h eb69685 
>   plasmoid/applet/nuclearPlasmoid/nuclearCalculator.h 0092f39 
>   plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp 0e5ed5a 
>   plasmoid/applet/psePlasmoid/Molmasscalculator.h 6c50ee2 
>   plasmoid/applet/psePlasmoid/Molmasscalculator.cpp 1c7359d 
>   plasmoid/applet/didyouknow/didyouknow.h 281439d 
>   plasmoid/applet/didyouknow/didyouknow.cpp 6e96fba 
>   plasmoid/applet/gasPlasmoid/gasCalculator.h 6ac9023 
>   plasmoid/applet/gasPlasmoid/gasCalculator.cpp 0b3941a 
>   plasmoid/applet/nuclearPlasmoid/kalziumdataobject.h e284ce8 
>   plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp 4a07d8e 
>   compoundviewer/kalziumglwidget.h 53e7070 
>   compoundviewer/kalziumglwidget.cpp ec7d918 
>   compoundviewer/libkdeedu_compoundviewer_export.h 5b0bc7d 
>   compoundviewer/openbabel2wrapper.h d45cdf2 
>   compoundviewer/openbabel2wrapper.cpp 4a7e0f8 
>   libscience/chemicaldataobject.h dd5d6d6 
>   libscience/chemicaldataobject.cpp 66214f8 
>   libscience/element.h d81ec5e 
>   libscience/element.cpp 1d1370d 
>   libscience/elementparser.h f7459e0 
>   libscience/elementparser.cpp 3a09788 
>   libscience/isotope.h 6565075 
>   libscience/isotope.cpp 3c94ecc 
>   libscience/isotopeparser.h 7e1107d 
>   libscience/isotopeparser.cpp 040b8db 
>   libscience/libkdeedu_science_export.h e9343e5 
>   libscience/moleculeparser.h 705154f 
>   libscience/moleculeparser.cpp 377e315 
>   libscience/parser.h 2cbfad3 
>   libscience/parser.cpp 223463b 
>   libscience/psetables.h bdcbcdd 
>   libscience/psetables.cpp b8e5654 
>   libscience/spectrum.h 14f5c42 
>   libscience/spectrum.cpp c9e4f27 
>   libscience/spectrumparser.h 00f800a 
>   libscience/spectrumparser.cpp 2209af3 
>   libscience/tests/isotopereadingtest.cpp 1855a4e 
>   libscience/tests/spectrumreadingtests.cpp 4eb582b 
>   libscience/tests/xmlreadingtest.cpp 37f9a8f 
>   plasmoid/applet/bodr/kalzium_plasma.h 975d9d9 
>   plasmoid/applet/bodr/kalzium_plasma.cpp a4d9912 
>   plasmoid/applet/concentrationPlasmoid/concentrationCalculator.h 586387d 
>   plasmoid/applet/concentrationPlasmoid/concentrationCalculator.cpp 32b38e5 
> 
> Diff: https://git.reviewboard.kde.org/r/120238/diff/
> 
> 
> Testing
> -------
> 
> * compiling
> * starting the program (did not test all features)
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140917/9ed770ab/attachment-0001.html>

More information about the kde-edu mailing list