Review Request 120233: Further port to frameworks so that pairs builds

Aleix Pol Gonzalez aleixpol at kde.org
Tue Sep 16 17:35:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120233/#review66697
-----------------------------------------------------------

Ship it!


Looks good, I'll push it.

- Aleix Pol Gonzalez


On Sept. 16, 2014, 2:14 p.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120233/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 2:14 p.m.)
> 
> 
> Review request for KDE Edu, Marco Calignano and David Edmundson.
> 
> 
> Repository: pairs
> 
> 
> Description
> -------
> 
> Further completion of the port to frameworks. This now allows pairs to be build
> 
> 
> Diffs
> -----
> 
>   icons/hi96-apps-pairs.png f5ff63c 
>   icons/hi96-apps-pairseditor.png 820ef2e 
>   icons/hisc-apps-pairs.svgz 4d1be5d 
>   icons/hisc-apps-pairseditor.svgz 069f317 
>   icons/sc-apps-pairs.svgz PRE-CREATION 
>   icons/sc-apps-pairseditor.svgz PRE-CREATION 
>   pairseditor/CMakeLists.txt 3b92898 
>   pairseditor/elementitem.cpp 2b19cf9 
>   pairseditor/main.cpp 8b70e36 
>   pairseditor/mainwindow.cpp ef206fe 
>   pairseditor/mainwindowview.cpp 2dac0d2 
>   icons/hi256-apps-pairseditor.png bc8f5c3 
>   icons/hi32-apps-pairs.png 21cc9d5 
>   icons/hi32-apps-pairseditor.png eb6ac8c 
>   icons/hi36-apps-pairs.png 13ca1b4 
>   icons/hi36-apps-pairseditor.png eae8aae 
>   icons/hi48-apps-pairs.png 66b6279 
>   icons/hi48-apps-pairseditor.png 9fef98b 
>   icons/hi64-apps-pairs.png 958542c 
>   icons/hi64-apps-pairseditor.png e682df3 
>   icons/hi22-apps-pairseditor.png 0f1bb02 
>   icons/hi24-apps-pairs.png 81ac40a 
>   icons/hi24-apps-pairseditor.png 4b74217 
>   icons/hi256-apps-pairs.png bc349cd 
>   icons/hi128-apps-pairseditor.png 1271f6d 
>   icons/hi16-apps-pairs.png 18d0688 
>   icons/hi16-apps-pairseditor.png 6dc0fbc 
>   icons/hi192-apps-pairs.png 48ea860 
>   icons/hi192-apps-pairseditor.png 38b8784 
>   icons/hi22-apps-pairs.png cf1e3d5 
>   icons/16-apps-pairseditor.png PRE-CREATION 
>   icons/192-apps-pairs.png PRE-CREATION 
>   icons/192-apps-pairseditor.png PRE-CREATION 
>   icons/22-apps-pairs.png PRE-CREATION 
>   icons/22-apps-pairseditor.png PRE-CREATION 
>   icons/24-apps-pairs.png PRE-CREATION 
>   icons/24-apps-pairseditor.png PRE-CREATION 
>   icons/256-apps-pairs.png PRE-CREATION 
>   icons/256-apps-pairseditor.png PRE-CREATION 
>   icons/32-apps-pairs.png PRE-CREATION 
>   icons/32-apps-pairseditor.png PRE-CREATION 
>   icons/36-apps-pairs.png PRE-CREATION 
>   icons/36-apps-pairseditor.png PRE-CREATION 
>   icons/48-apps-pairs.png PRE-CREATION 
>   icons/48-apps-pairseditor.png PRE-CREATION 
>   icons/64-apps-pairs.png PRE-CREATION 
>   icons/64-apps-pairseditor.png PRE-CREATION 
>   icons/96-apps-pairs.png PRE-CREATION 
>   icons/96-apps-pairseditor.png PRE-CREATION 
>   icons/CMakeLists.txt 8994e4b 
>   icons/hi128-apps-pairs.png 0a44861 
>   CMakeLists.txt b13d4a6 
>   icons/128-apps-pairs.png PRE-CREATION 
>   icons/128-apps-pairseditor.png PRE-CREATION 
>   icons/16-apps-pairs.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120233/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140916/3d353aa6/attachment-0001.html>


More information about the kde-edu mailing list