Review Request 120219: Fix bug #338666: "Kalzium crashes when selecting >File >Export Data..."

[Martin Walch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120219/
-----------------------------------------------------------

(Updated Sept. 15, 2014, 4:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Bugs: 338666
    http://bugs.kde.org/show_bug.cgi?id=338666


Repository: kalzium


Description
-------

Problem is easy to spot with valgrind:
The private ExportDialog *m_exportDialog is not explicitely initialized
with 0, so later calling "if (!m_exportDialog)" may fail.

This accidentally slipped in with a header cleanup (commit d36687d50...)

Easy fix: initialize the pointer with 0 just like all the others.

BUG: 338666
FIXED-IN: 4.14.2

REVIEW: 120219


Diffs
-----

  src/kalzium.cpp da7f315 

Diff: https://git.reviewboard.kde.org/r/120219/diff/


Testing
-------

* compiling
* running
* bug did not appear any more

(all on KDE 4.14.0)


Thanks,

Martin Walch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140915/ade0a24d/attachment.html>