Review Request 120129: Fix Iteration of Array mm

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120129/
-----------------------------------------------------------

(Updated Sept. 12, 2014, 1:47 p.m.)


Review request for KDE Edu, Maurizio Paolini and Rex Dieter.


Changes
-------

Iterate using for loops


Bugs: 338978
    http://bugs.kde.org/show_bug.cgi?id=338978


Repository: kig


Description
-------

Because of the initial value of j it was missing j = 1, causing Valgrind to report a jump over uninitialized value. Because of the check at the while loop, it was modifying j = N + 1, causing a stack buffer overflow.


Diffs (updated)
-----

  objects/curve_imp.cc 12931c8 

Diff: https://git.reviewboard.kde.org/r/120129/diff/


Testing
-------

Valgrinded an execution of Kig creating a locus as described in the bug report.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140912/c675acd3/attachment.html>