Review Request 120923: Remove unused dependencies.

Jeremy Whiting jpwhiting at kde.org
Fri Oct 31 19:05:50 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120923/#review69607
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Whiting


On Oct. 31, 2014, 11:06 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120923/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 11:06 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> Tests use QCoreApplication from QtCore instead of QApplication from QtWidgets allowing that dependency to be dropped. QFont header is not used at all. KF5Config does not appear to be used at all.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a37ddc59bd56e47a96cd211da57c2e99c8eba9c0 
>   keduvocdocument/CMakeLists.txt a207f3edce9ff726209c3a21a0c069d3f296ad38 
>   keduvocdocument/readerwriters/keduvocwqlreader.cpp 539246efa84b4dcc74121a78c20c0dfa2187b097 
>   keduvocdocument/tests/CMakeLists.txt 87182511d4e8fa4c03fc0a7d3644cc57dde19469 
>   keduvocdocument/tests/converter.cpp b97d55ad5f764748a9f7f0487f94d9db1ac99371 
>   keduvocdocument/tests/sharedkvtmlfilestest.cpp 4893485473357ff8be279c8850674f9dea8fef89 
> 
> Diff: https://git.reviewboard.kde.org/r/120923/diff/
> 
> 
> Testing
> -------
> 
> Inspected source, builds, tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141031/9960c141/attachment-0001.html>


More information about the kde-edu mailing list