Review Request 120895: Use new format for generating filter string for QDialog use.

Inge Wallin inge at lysator.liu.se
Wed Oct 29 19:52:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120895/#review69480
-----------------------------------------------------------

Ship it!


I haven't tested it but if it works for you then ship it.  It's not a very big change...

- Inge Wallin


On Oct. 29, 2014, 7:44 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120895/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 7:44 p.m.)
> 
> 
> Review request for KDE Edu, Andreas Xavier and Inge Wallin.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> QFileDialog filter strings have name (*.ext) and are separated by ;; instead of newlines.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvocdocument.cpp b73025b6e5835f661c7dadeb6f93cd80f4279336 
> 
> Diff: https://git.reviewboard.kde.org/r/120895/diff/
> 
> 
> Testing
> -------
> 
> Parley open file now shows all the filters, not just csv.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141029/46da86fc/attachment-0001.html>


More information about the kde-edu mailing list