Review Request 120838: Fix quit action by connecting it to qApp instead of kapp.

Laurent Navet laurent.navet+kde at gmail.com
Tue Oct 28 19:17:41 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120838/#review69330
-----------------------------------------------------------

Ship it!


seems good !

- Laurent Navet


On Oct. 28, 2014, 6:49 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120838/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 6:49 a.m.)
> 
> 
> Review request for KDE Edu and Laurent Navet.
> 
> 
> Repository: klettres
> 
> 
> Description
> -------
> 
> KLettres doesn't use KApplication anymore, so connect to
> the QApplication's quit slot instead.
> 
> 
> Diffs
> -----
> 
>   src/klettres.cpp 0390a52b2ef425277d9b19a4ef1e2e9876a585df 
> 
> Diff: https://git.reviewboard.kde.org/r/120838/diff/
> 
> 
> Testing
> -------
> 
> File -> Quit now actually does what it should.
> 
> Seems a lot of the stuff in setupActions isn't showing in the ui yet, something got missed when porting to frameworks I guess.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141028/8910fe78/attachment.html>


More information about the kde-edu mailing list