Review Request 120789: Moved standardthemes.xml to khangman/themes

Jeremy Whiting jpwhiting at kde.org
Fri Oct 24 21:35:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120789/#review69120
-----------------------------------------------------------



src/desktop/khmthemefactory.cpp
<https://git.reviewboard.kde.org/r/120789/#comment48323>

    Looks good but this qDebug isn't needed.


- Jeremy Whiting


On Oct. 24, 2014, 3:31 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120789/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 3:31 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> standardthemes.xml was initially getting installed in khangman/install/share/khangman/pics , and the location was changed to khangman/themes
> 
> 
> Diffs
> -----
> 
>   src/desktop/khangman.cpp 2d3ed0fc8841a44ba076d02c06a066d9445b2f8b 
>   src/desktop/khmthemefactory.cpp 227a5790153ddc0dfbc8fc323f06d033ddec4a4e 
>   themes/CMakeLists.txt 90cfb55c40b7bfbdf9ced4ecb8d57610c900a373 
> 
> Diff: https://git.reviewboard.kde.org/r/120789/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141024/1f3717f5/attachment.html>


More information about the kde-edu mailing list