Review Request 120769: Fix Quit button functionality

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120769/#review69060
-----------------------------------------------------------


Besides these two items it looks good. Fix them and repost here.


src/desktop/khangman.cpp
<https://git.reviewboard.kde.org/r/120769/#comment48293>

    We don't need quitAction connected to queryClose at all, just replace that with close() and remove the other connect.



src/desktop/khangman.cpp
<https://git.reviewboard.kde.org/r/120769/#comment48294>

    No need to leave this commented out line, just remove it.


- Jeremy Whiting


On Oct. 23, 2014, 4:41 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120769/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 4:41 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> The Quit button present on the menubar did not close the application. However on connecting the quit action with close() it now works successfully.
> 
> 
> Diffs
> -----
> 
>   src/desktop/khangman.h 4a022a1cff2676ca98a4f81f25c3a0c5142a1657 
>   src/desktop/khangman.cpp 565311424d3cefd3634646da69fa7928f777eff2 
>   src/desktop/khangmanview.cpp 9c8e48e17b58ccc4b2772f59d493a05a18dbbe15 
> 
> Diff: https://git.reviewboard.kde.org/r/120769/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141023/fce3a66a/attachment.html>