Review Request 120738: fix crash when no themes are found

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120738/#review68978
-----------------------------------------------------------



src/desktop/khangman.cpp
<https://git.reviewboard.kde.org/r/120738/#comment48242>

    This will leak. Use the static methods, like QMessageBox::information.
    
    Or assert, it doesn't seem to be very logical not to be able to end up in a valid scenario without themes.
    
    Also note the coding style, the else shouldn't go into a new line.
    
    } else {


- Aleix Pol Gonzalez


On Oct. 23, 2014, 7:19 a.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120738/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 7:19 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> If the theme files are not found, the app crashes. To fix that, the show() method has been changed. It checks if the theme files exist. If none is found, a QMessageBox is displayed and the app closes. Else the theme is loaded by calling the appropriate slot.
> 
> 
> Diffs
> -----
> 
>   src/desktop/khangman.h 80f4552 
>   src/desktop/khangman.cpp a486ea4 
> 
> Diff: https://git.reviewboard.kde.org/r/120738/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141023/8a22168c/attachment.html>