Review Request 120727: Making Kletters portable to Kf5 framework by removing kf5umbrella dependencies

[Jeremy Whiting]

Good Idea, I just asked in #kde-sysadmin how to add new projects to the ci
system.

On Wed, Oct 22, 2014 at 4:55 PM, Aleix Pol <aleixpol at kde.org> wrote:

> On Wed, Oct 22, 2014 at 10:22 PM, Subhajit Mukherjee <subho020m at gmail.com>
> wrote:
>
>>    This is an automatically generated e-mail. To reply, visit:
>> https://git.reviewboard.kde.org/r/120727/
>>   This change has been marked as submitted.
>>   Review request for KDE Edu and Jeremy Whiting.
>> By Subhajit Mukherjee.
>>
>> *Updated Oct. 22, 2014, 8:22 p.m.*
>>  *Repository: * klettres
>> Description
>>
>> As kf5umbrella is almost dead now, the framework branch of the git repository for klettres was not compiling in the KF5 framework. I think it's possible that it still depends on KF5Umbrella but on removing the "CONFIG" keyword from CMakeLists.txt on line 23 , it compiled and ran successfully.
>>
>>   Diffs
>>
>>    - CMakeLists.txt (2324acb)
>>
>> View Diff <https://git.reviewboard.kde.org/r/120727/diff/>
>>
>> _______________________________________________
>> kde-edu mailing list
>> kde-edu at mail.kde.org
>> https://mail.kde.org/mailman/listinfo/kde-edu
>>
>>
> Isn't this being run in build.kde.org? If not, then it should.
>
> Aleix
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141022/e3bdccde/attachment.html>