Review Request 120721: Fix startup segfault crash

Rahul Chowdhury rahulc93 at gmail.com
Wed Oct 22 15:33:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120721/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 3:33 p.m.)


Review request for KDE Edu and Jeremy Whiting.


Repository: khangman


Description
-------

Initially the app used to crash when started, and returned segmentation fault. In the KHangman class the show() function of KXmGuiWindow is overriden, which now checks for the kvtml files first. If no files are found, a QMessageBox is displayed, otherwise the mainwindow is loaded.


Diffs (updated)
-----

  src/desktop/khangman.h cf8465274e064e6ee374cdb87c83a62341a25880 
  src/desktop/khangman.cpp 71fcf6b805f517ee525bede0b6bac7ad523814de 
  src/desktop/main.cpp b121ddd3168ffe583486d63ef702aa70d686c911 
  src/engine/khangmanengine.cpp c8eeb84046f99c64df8614f3868d6eee6b6aadfe 

Diff: https://git.reviewboard.kde.org/r/120721/diff/


Testing
-------


Thanks,

Rahul Chowdhury

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141022/406a90f2/attachment-0001.html>


More information about the kde-edu mailing list