Review Request 120721: Fix startup segfault crash

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120721/#review68913
-----------------------------------------------------------


This looks pretty good, good job.


src/desktop/khangman.cpp
<https://git.reviewboard.kde.org/r/120721/#comment48181>

    This looks pretty good, I would remove the qDebug() lines though, they shouldn't be needed now that the problem is solved. So this if around close() shouldn't be needed anymore either.



src/desktop/khangman.cpp
<https://git.reviewboard.kde.org/r/120721/#comment48182>

    No need to return; it will return outside the else block anyway.



src/desktop/khangman.cpp
<https://git.reviewboard.kde.org/r/120721/#comment48183>

    this qDebug is still useful, but the other ones you've added should be removed



src/desktop/khangman.cpp
<https://git.reviewboard.kde.org/r/120721/#comment48184>

    No need to leave commented out code, just remove it instead.


This looks pretty good, good job. Just clean up the few things mentioned and we can push this to git. That means fix these things, do git commit --amend to add these fixes to your original commit, then either do rbt post -r 120721 or make a patch from git again and update the patch on the website.

- Jeremy Whiting


On Oct. 22, 2014, 8:15 a.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120721/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 8:15 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> Initially the app used to crash when started, and returned segmentation fault. In the KHangman class the show() function of KXmGuiWindow is overriden, which now checks for the kvtml files first. If no files are found, a QMessageBox is displayed, otherwise the mainwindow is loaded.
> 
> 
> Diffs
> -----
> 
>   src/desktop/main.cpp b121ddd 
>   src/engine/khangmanengine.cpp c8eeb84 
>   src/desktop/khangman.cpp 71fcf6b 
>   src/desktop/khangman.h cf84652 
> 
> Diff: https://git.reviewboard.kde.org/r/120721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141022/27f069b1/attachment.html>