Review Request 120703: Optimize writing of black color in pgf output

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120703/
-----------------------------------------------------------

Review request for KDE Edu and David Narváez.


Bugs: 340213
    http://bugs.kde.org/show_bug.cgi?id=340213


Repository: kig


Description
-------

Write "color=black" instead of "color={rgb:red,0;green,0;blue,0}". Appearantly, there is a bug in Ubuntu 14.04 LTS Latex, which causes a floating point error when all components are 0, probably because it tries to convert it to a different colorspace, without handling the 0 case.

While we should not work around this bug, we still can apply this to "optimize" the produced .pgf file, both in file size, as well as in readability.

The referenced bug report also suggests to do this for other special colors, but I am not sure if "red" is really 255,0,0 in PGF, and I was to lazy to check this. It is not required for the workaround, either.


Diffs
-----

  filters/pgfexporterimpvisitor.cc 3065338 

Diff: https://git.reviewboard.kde.org/r/120703/diff/


Testing
-------


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141021/199ad1b9/attachment.html>