Review Request 120567: Porting Cantor Python2 backend to Python3

[Minh Ngo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120567/
-----------------------------------------------------------

(Updated Oct. 12, 2014, 7:56 p.m.)


Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.


Repository: cantor


Description
-------

Hi,

I have ported Python2 backend to Python3.

There is some bug in the default cmake script for finding PythonLibs script so it cannot find PythonLibs3 now http://www.cmake.org/Bug/print_bug_page.php?bug_id=13794, therefore I decided to write my own script (FindPythonLibs3.cmake).

Headers moving were made to make it compilible. See more: http://stackoverflow.com/questions/20300201/why-python-h-of-python-3-2-must-be-included-as-first-together-with-qt4

Regards,

Minh


Diffs
-----

  src/backends/python3/python3backend.desktop PRE-CREATION 
  src/backends/python3/python3backend.kcfg PRE-CREATION 
  cmake/FindPythonLibs3.cmake PRE-CREATION 
  src/backends/CMakeLists.txt 687e5d6 
  src/backends/python2/python2backend.cpp 2b724f1 
  src/backends/python2/python2backend.kcfg 22564c1 
  src/backends/python2/python2completionobject.cpp 08c00c3 
  src/backends/python2/python2expression.cpp 32a7380 
  src/backends/python2/python2session.h bb6650d 
  src/backends/python2/python2session.cpp 513f6ec 
  src/backends/python2/python2utils.h PRE-CREATION 
  src/backends/python3/CMakeLists.txt PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120567/diff/


Testing
-------

Looks like it works :)

Have done some simple things like that:
import numpy as np
a = np.array([1, 2, 3])
print(a)


Thanks,

Minh Ngo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141012/4000856d/attachment.html>