Review Request 121287: Fix autosave and save issues on windows

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121287/#review71067
-----------------------------------------------------------

Ship it!


Looks good.  I just think that the fact we use toDisplayString() instead of path() should be commented upon somewhere.


keduvocdocument/keduvocdocument.cpp
<https://git.reviewboard.kde.org/r/121287/#comment49644>

    There are so many instances of this call so it's difficult to know where it's best.  But I do think that we need a comment somewhere to comment on the fact that url.path() doesn't work. And frankly, that feels like a bug in QUrl to me.


- Inge Wallin


On Nov. 28, 2014, 10:59 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121287/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2014, 10:59 p.m.)
> 
> 
> Review request for KDE Edu, Andreas Xavier and Inge Wallin.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> Before this patch parley on windows has issues saving to any new file, and also saving an existing .kvtml file.
> With this patch both issues are fixed.
> On windows QUrl .path() returns the path without the drive letter. Changing it to use QUrl .toDisplayString() fixed that here.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/autosave/kautosavefileprivate.cpp bb2c845 
>   keduvocdocument/keduvocdocument.cpp dbaef89 
> 
> Diff: https://git.reviewboard.kde.org/r/121287/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs and fixes the bug on windows. Will test on linux later on.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141128/64bae5cf/attachment.html>