Review Request 121184: Adjust dashboard to have QScrollArea around collection widgets.

Jeremy Whiting jpwhiting at kde.org
Thu Nov 20 22:37:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121184/
-----------------------------------------------------------

(Updated Nov. 20, 2014, 3:37 p.m.)


Review request for KDE Edu, Andreas Xavier, Inge Wallin, and Marko Käning.


Changes
-------

Updated ui to make the heading label take 1 row instead of 2 like it does in my patch on Applications/14.12 and master.


Repository: parley


Description
-------

(cherry picked from commit 77e86e4a6cb806a9ad952c1a6ff3966be988c0f2)

Conflicts:
	src/dashboard/collectionwidget.cpp
	src/dashboard/dashboard.cpp
	src/dashboard/dashboard.ui


Diffs (updated)
-----

  src/dashboard/collectionwidget.cpp 6898d1902bfdd64f615dd7350dcc9c477225908e 
  src/dashboard/dashboard.h b72722c02f730b7ea27065b17ca531bd96c32f43 
  src/dashboard/dashboard.cpp 11eb5bbc2d379d0d770b53181adf5416504732b9 
  src/dashboard/dashboard.ui 70c7eb180b6465d520f0547aa12925c64aa5c71f 

Diff: https://git.reviewboard.kde.org/r/121184/diff/


Testing
-------

It builds and runs and the scrollarea scrollbars appear when the view gets too small as expected.

I have similar commits for Applications/14.12 and master here that we can review separately or just push that do the same thing.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141120/f58cb643/attachment.html>


More information about the kde-edu mailing list