Review Request 121139: Add Navigation with up, down and ESC keys to the overlay menu

Andreas Cord-Landwehr cordlandwehr at kde.org
Wed Nov 19 20:36:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121139/#review70667
-----------------------------------------------------------


Changes look fine to me and with QtQuick1+PlasmaComponents this is problably the easiest way to implement it.

Adding Sebastian as reviewer.

- Andreas Cord-Landwehr


On Nov. 16, 2014, 4:40 nachm., Dieter Piringer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121139/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2014, 4:40 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: ktouch
> 
> 
> Description
> -------
> 
> The overlay menu ist is the menu you get when you click the "home" button top left while in a training.
> Don't want to have have to use the mouse for selecting one of the other two options before hitting enter.
> Also the ESC key closes the dialog again.
> 
> 
> Diffs
> -----
> 
>   src/qml/TrainingScreenMenuOverlay.qml bf37e12c9bb14e2991551a5ee2556798f3ccbcd0 
> 
> Diff: https://git.reviewboard.kde.org/r/121139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dieter Piringer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141119/b489ef40/attachment.html>


More information about the kde-edu mailing list