Review Request 121170: Use QLocale to get language names.

Laurent Navet laurent.navet+kde at gmail.com
Tue Nov 18 20:24:58 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121170/#review70608
-----------------------------------------------------------

Ship it!


Ship it!

- Laurent Navet


On Nov. 18, 2014, 6:24 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121170/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 6:24 p.m.)
> 
> 
> Review request for KDE Edu and Laurent Navet.
> 
> 
> Repository: klettres
> 
> 
> Description
> -------
> 
> all_languages has become kf5_all_languages, but QLocale gives us
> native language names, so just use it like we do in KHangMan, KAnagram, etc.
> 
> 
> Diffs
> -----
> 
>   src/langutils.cpp 2343cd9f49f8028d48942dbd58e751a2e50f79f5 
> 
> Diff: https://git.reviewboard.kde.org/r/121170/diff/
> 
> 
> Testing
> -------
> 
> Without this patch the Language menu says "None" for every language we have data for. With it the language names are shown in their native language.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141118/2dddee57/attachment.html>


More information about the kde-edu mailing list