Review Request 121127: Let a user open a file in read-only mode.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121127/
-----------------------------------------------------------

(Updated Nov. 15, 2014, 3:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Jeremy Whiting.


Repository: libkeduvocdocument


Description
-------

When Parley introduced the dashboard, the intention was to show some basic information about all the KVTML files that the user are interested in. But to do that it has to open them, read them, and process them a little.

The problem is that to do this, it has to steal the lock from other applications since there is no open in read-only mode in the library.

This patch introduces such a read-only mode. The file is opened and read as usual but all locks are ignored. On the other hand, the file will also be blocked from saving so there is no room for error. In the future we can perhaps implement a call that changes mode from read-only to read-write and also asks the user if he wants to steal the lock, but that is not part of this patch.


Diffs
-----

  keduvocdocument/keduvocdocument.h 7af2c12 
  keduvocdocument/keduvocdocument.cpp b376270 

Diff: https://git.reviewboard.kde.org/r/121127/diff/


Testing
-------

No testing at this point. I am asking for a visual inspection.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141115/99d15fcd/attachment.html>