Review Request 118310: support for graphic properties of Geogebra objects in KIG

[Aniket Anvit]

> On July 15, 2014, 4 a.m., Albert Astals Cid wrote:
> > ping?
> 
> Albert Astals Cid wrote:
>     ping #2
> 
> David Narváez wrote:
>     I think this one was ready back in the day. Aniket, can you update the patch and update the testing done? or is this waiting on something else?

We had put it on hold since we hadn't added added support for all the objects ( some were left like - angles, loci, intersection, tangents ...). The plan was to add all the left ones and then add this patch. But I think we should go ahead and commit this one. I am updating the patch.


- Aniket


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118310/#review62348
-----------------------------------------------------------


On May 25, 2014, 11:51 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118310/
> -----------------------------------------------------------
> 
> (Updated May 25, 2014, 11:51 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch enables KIG to read the graphic properties of Geogebra objects from Geogebra worksheets.
> Here is some explanation about my implementation:
>   
> the graphic properties ( lineStyle, pointStyle, lineWidth, color ) are read for each geogebra object. I add an attribute for each property to each of the intermediate representation of each of the objects created using XSLT. Some variables are added to the KigFilterGeogebra class to hold the values of the properties for each of the objects. In the attribute() callback method of the KigFilterGeogebra class , the values of the properties are read ( and suitably mapped to KIG's ) and when the endElement() callback is called a new ObjectDrawer with the last read properties is allocated for this object.
> 
> 
> Diffs
> -----
> 
>   filters/geogebra-filter.h ebf5713 
>   filters/geogebra-filter.cpp a0fc6b4 
>   filters/geogebra.xsl e52fc1d 
> 
> Diff: https://git.reviewboard.kde.org/r/118310/diff/
> 
> 
> Testing
> -------
> 
> Tested! some trouble in the mapping of PointStyles.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141114/49cc1103/attachment-0001.html>