Review Request 120925: Remove unused dependencies.

[Jeremy Whiting]

> On Nov. 9, 2014, 3:12 p.m., Jeremy Whiting wrote:
> > I'm pretty sure we want Crash and KIO for drkonqi on segfaults (though those should be solved with graceful closing by now) and libkeduvocdocument uses kio for loading kvtml files if needed I believe. The Qt5 dependencies are probably right though.
> 
> Michael Palimaka wrote:
>     drkonqi appears to be provided by plasma-workspace, not any framework. libkeduvocdocument does indeed need kio and it's searched for there.

Ah, I see the problem. KF5::Crash wasn't added to the target_link_libraries. I'll add that now. Also will remove the QtWebkit, since we aren't using it. Yes drkonqi is in plasma-workspace, but if we don't link to KF5::Crash it doesn't invoke drkonqi.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120925/#review70143
-----------------------------------------------------------


On Oct. 31, 2014, 3:53 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120925/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 3:53 p.m.)
> 
> 
> Review request for KDE Edu, Rahul Chowdhury and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> I can't find any usage of these dependencies, so remove them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9cdfcbf1109fe326ef05c7dbd89c80c275a303db 
> 
> Diff: https://git.reviewboard.kde.org/r/120925/diff/
> 
> 
> Testing
> -------
> 
> Inspected source, builds, runs.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141113/dba05296/attachment.html>