Review Request 118307: support for Geogebra's Angle objects in KIG ( GSoC 14 )

[David Narváez]

> On May 27, 2014, 7:24 p.m., David Narváez wrote:
> > This one is pretty straightforward, but I messed the diff by commiting my formatting changes (I'm very annoying, I know). Could you refresh the diff please (taking care of formatting, of course)?
> > 
> > Also, in the "Testing done" field, that is not a boolean question, you have to write what you did to test it in a way that people reviewing the diff can reproduce your test results.
> 
> Albert Astals Cid wrote:
>     ping?
> 
> Albert Astals Cid wrote:
>     ping #2

I think this one was ready back in the day. Aniket, can you update the patch and update the testing done? or is this waiting on something else?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118307/#review58602
-----------------------------------------------------------


On May 25, 2014, 5:59 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118307/
> -----------------------------------------------------------
> 
> (Updated May 25, 2014, 5:59 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch enables KIG to read Angle objects from Geogebra worksheets.
> 
> 
> Diffs
> -----
> 
>   filters/geogebra-filter.cpp a0fc6b4 
>   filters/geogebra.xsl e52fc1d 
> 
> Diff: https://git.reviewboard.kde.org/r/118307/diff/
> 
> 
> Testing
> -------
> 
> Tested!
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141112/df2bff54/attachment.html>