Review Request 121026: Parley: Finally make the "due words" feature work.

[Inge Wallin]

> On Nov. 7, 2014, 12:54 a.m., Jeremy Whiting wrote:
> > src/collection/collection.h, line 3
> > <https://git.reviewboard.kde.org/r/121026/diff/1/?file=326629#file326629line3>
> >
> >     These are new files, right? probably don't need/want Frederik in the copyright of files you created.

It's a partial copy of another file that Fredrik did co-write. So I think it's appropriate to keep it.


> On Nov. 7, 2014, 12:54 a.m., Jeremy Whiting wrote:
> > src/collection/collection.h, line 25
> > <https://git.reviewboard.kde.org/r/121026/diff/1/?file=326629#file326629line25>
> >
> >     No need for a new commented out include.

Indeed.  This is a trace from the copy.


> On Nov. 7, 2014, 12:54 a.m., Jeremy Whiting wrote:
> > src/collection/entryfilter.h, line 42
> > <https://git.reviewboard.kde.org/r/121026/diff/1/?file=326631#file326631line42>
> >
> >     Should probably update the apidocs when adding a parameter.

Right.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121026/#review69957
-----------------------------------------------------------


On Nov. 7, 2014, 12:34 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121026/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 12:34 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This patch fixes the so far non-working "due words" feature, which lets the user know how many words are due to practice in each collection in the dashboard.
> 
> 
> Diffs
> -----
> 
>   TODO 3a694f5 
>   src/CMakeLists.txt 3be2282 
>   src/collection/collection.h PRE-CREATION 
>   src/collection/collection.cpp PRE-CREATION 
>   src/collection/entryfilter.h 72cf026 
>   src/collection/entryfilter.cpp 4668e6f 
>   src/collection/testentry.h 572cb26 
>   src/collection/testentry.cpp 04ba8b9 
>   src/dashboard/barwidget.h bcefa6f 
>   src/dashboard/barwidget.cpp 593cd71 
>   src/dashboard/collectionwidget.h 814ece6 
>   src/dashboard/collectionwidget.cpp 573e928 
>   src/dashboard/dashboard.h ac16592 
>   src/dashboard/dashboard.cpp 55413fc 
>   src/practice/sessionmanagerbase.cpp b45e591 
> 
> Diff: https://git.reviewboard.kde.org/r/121026/diff/
> 
> 
> Testing
> -------
> 
> As usual, testing on real-world data in my own studies.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141107/75f1ade7/attachment.html>