KStars master is KF5 based?

[Albert Astals Cid]

El Dimecres, 5 de novembre de 2014, a les 21:55:26, Jasem Mutlaq va escriure:
> Fine, if KStars is going to be delayed for Beta 2, can we use the
> Application/14.12 branch that is now based on KF5, or are we required to
> revert back to KDE4?

I'm not going to ship a KF5 based KStars. It was commited late into the 
process, so that's not acceptable.

Please make it so that the Application/14.12 branch has the correct code that 
was in it when i forked it from master.

If you have a valid git hash some of the project admins should be able to 
delete the branch and create it again from that hash.

Albert

> 
> Regards,
> Jasem
> 
> On Wed, Nov 5, 2014 at 9:50 PM, Albert Astals Cid <aacid at kde.org> wrote:
> > El Dimecres, 5 de novembre de 2014, a les 08:13:02, Jasem Mutlaq va
> > 
> > escriure:
> > > For some reason, I thought the freeze starts today. My mistake, it was
> > 
> > Oct
> > 
> > > 29th. Is it possible to revert the merge on Application/14.12 branch? I
> > > read on how to revert a branch merge after push, but I don't want to
> > 
> > cause
> > 
> > > more damage inadvertently. This was an oversight and I do apologize for
> > 
> > the
> > 
> > > inconvenice it caused you.
> > 
> > Sorry but i do not have time to fix this.
> > 
> > I will simply not release KStars as part of 14.12 Beta 1.
> > 
> > If you or someone have time to fix this in time for Beta 2 I will include
> > it.
> > Otherwise KStars will have to miss the 14.12 release altogether.
> > 
> > Best Regards,
> > 
> >   Albert
> >   
> > > Furthermore, would it be possible to remove the frameworks branch since
> > > people apparently are still committing to it.
> > > 
> > > Regards,
> > > Jasem
> > > 
> > > On Wed, Nov 5, 2014 at 1:38 AM, Albert Astals Cid <aacid at kde.org> wrote:
> > > > El Dimecres, 5 de novembre de 2014, a les 00:00:54, Jasem Mutlaq va
> > > > 
> > > > escriure:
> > > > > Affirmative, KStars master is KF5 based now. I have sent an email to
> > 
> > the
> > 
> > > > > kstars list 2 weeks ago, and again yesterday and today regarding
> > > > > this
> > > > > switch. I hope this doesn't cause too much trouble for Applications
> > > > > 14.12
> > > > > release.
> > > > 
> > > > I'm not sure i'm reading git log correctly but you merged the KF5
> > 
> > branch
> > 
> > > > to
> > > > Applications 14.12 today several days after the freeze is in place?
> > > > 
> > > > And all you can say is "hope doesn't cause too much trouble"?
> > > > 
> > > > If you did that, it is totally out of line. How am i suposed to
> > > > release
> > > > something tomorrow?
> > > > 
> > > > Albert
> > > > 
> > > > > Regards,
> > > > > Jasem
> > > > > 
> > > > > On Tue, Nov 4, 2014 at 11:29 PM, Marko Käning <mk-lists at email.de>
> > 
> > wrote:
> > > > > > On 04 Nov 2014, at 21:16 , Albert Astals Cid <aacid at kde.org>
> > 
> > wrote:
> > > > > > > El Dimarts, 4 de novembre de 2014, a les 13:45:41, Akarsh Simha
> > 
> > va
> > 
> > > > > > escriure:
> > > > > > >> Hi
> > > > > > >> 
> > > > > > >> I don't think this is the case -- I think master is not KF5
> > 
> > based,
> > 
> > > > but
> > > > 
> > > > > > >> the "frameworks" branch is KF5 based. Jasem, please correct me
> > 
> > if
> > 
> > > > I'm
> > > > 
> > > > > > >> wrong.
> > > > > > > 
> > > > > > > Master is defenitely KF5 based as we speak, i'm just asking if
> > > > 
> > > > that's a
> > > > 
> > > > > > > concious decision or a mistake.
> > > > > > 
> > > > > > Just 1-2h ago I've built kstars successfully on OSX/CI and it told
> > 
> > me
> > 
> > > > it
> > > > 
> > > > > > is
> > > > > > frameworks based:
> > > > > > 
> > > > > > ------------------------------------------
> > > > > > Project  : kde/kdeedu/kstars
> > > > > > Branch   : frameworks
> > > > > > Linux-CI : SUCCESS
> > > > > > Calling prepare script
> > > > > > Calling build script
> > > > > > ==========================================
> > > > > > 
> > > > > > The dependency information is up-to-date.
> > > > > > 
> > > > > > Greets,
> > > > > > Marko