Review Request 120995: KF5 Port : Port away from kdebug

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120995/#review69855
-----------------------------------------------------------

Ship it!


I've never seen qCDebug done with another .cpp and .h file rather than using an existing one, but that looks good to me. I wonder if you should put #include <QDebug> in klettres_debug.h so it wouldn't need to be included in all the other files where it's used. Either way is fine just a thought.

- Jeremy Whiting


On Nov. 4, 2014, 1:49 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120995/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 1:49 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: klettres
> 
> 
> Description
> -------
> 
> remove use of kdebug by using qCDebug instead.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt b6c6293 
>   src/klettres_debug.h PRE-CREATION 
>   src/klettres_debug.cpp PRE-CREATION 
>   src/klettresview.cpp 2b2d159 
>   src/langutils.cpp 059bc47 
>   src/soundfactory.cpp ad7a6b5 
> 
> Diff: https://git.reviewboard.kde.org/r/120995/diff/
> 
> 
> Testing
> -------
> 
> build and run.
> tests pass.
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141104/f10abc3b/attachment.html>