Review Request 120994: Fix quit connection by passing the address of the QApplication.

Andrius Štikonas andrius at stikonas.eu
Tue Nov 4 20:20:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120994/#review69850
-----------------------------------------------------------

Ship it!


Maybe use new Qt5 signal synax for consistency (all other slot/signals are converted)

QObject::connect(&app, &QApplication::lastWindowClosed, &app, &QApplication::quit);

- Andrius Štikonas


On lapkr. 4, 2014, 8:13 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120994/
> -----------------------------------------------------------
> 
> (Updated lapkr. 4, 2014, 8:13 p.m.)
> 
> 
> Review request for KDE Edu, Inge Wallin and Andrius Štikonas.
> 
> 
> Repository: kbruch
> 
> 
> Description
> -------
> 
> Fix quit connection by passing the address of the QApplication.
> 
> 
> Diffs
> -----
> 
>   src/KBruch.cpp eff85c03933283638841113399f87be73178f290 
> 
> Diff: https://git.reviewboard.kde.org/r/120994/diff/
> 
> 
> Testing
> -------
> 
> It builds, runs and quit/close windows closes the application.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141104/161a429c/attachment.html>


More information about the kde-edu mailing list