Review Request 120960: Install klettresui.rc in kxmlgui5 subdir so it can be found. Set application name to klettres to match the ui.rc file.
Burkhard Lück
lueck at hube-lueck.de
Tue Nov 4 03:42:41 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120960/#review69776
-----------------------------------------------------------
src/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120960/#comment48858>
frameworks/kxmlgui/src/kxmlguiclient.h reads:
* You should use ${KXMLGUI_INSTALL_DIR}/componentname in your CMakeLists.txt file, to install
* the .rc file(s).
- Burkhard Lück
On Nov. 3, 2014, 8:09 nachm., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120960/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 8:09 nachm.)
>
>
> Review request for KDE Edu and Laurent Navet.
>
>
> Repository: klettres
>
>
> Description
> -------
>
> Fixes menus and toolbar not appearing in the application.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 7de7efb43cf4dc4b36583105be31723a78c80e8a
> src/klettres.cpp b683081484cb4216b018358d808776136cad1904
> src/main.cpp 5a09bc7e26bbd9b83e61b6145041ecc0c9fcbe88
>
> Diff: https://git.reviewboard.kde.org/r/120960/diff/
>
>
> Testing
> -------
>
> Builds, runs and menus and toolbar are back as expected.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141104/1c6fd559/attachment-0001.html>
More information about the kde-edu
mailing list