Review Request 118349: Initial port for step to Qt5/KF5

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118349/#review58574
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40759>

    This commented lines should go.



CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40760>

    you can add DocTools on find_package(KF5). No need to make it conditional.



CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40761>

    This conditional can go, it's not needed anymore.



CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40762>

    feature_summary(WHAT ALL   FATAL_ON_MISSING_REQUIRED_PACKAGES)



step/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40763>

    Remove commented lines.



step/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40764>

    No need to invoke ECM again, remove find_package and includes.



step/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40765>

    Remove comment.



step/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40766>

    Remove comment



step/gasgraphics.cc
<https://git.reviewboard.kde.org/r/118349/#comment40767>

    If it's in a new file, this can go now.



step/icons/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40770>

    Remove comment



step/propertiesbrowser.cc
<https://git.reviewboard.kde.org/r/118349/#comment40768>

    Remove comment



step/propertiesbrowser.cc
<https://git.reviewboard.kde.org/r/118349/#comment40769>

    Turn it into a qWarning(). Remove the endl.



stepcore/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118349/#comment40771>

    Remove comment


Looks good as a first approach. Please remove the commented previous code and the issues pointed out here.

Thanks!

- Aleix Pol Gonzalez


On May 27, 2014, 12:57 p.m., Pepe Osca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118349/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 12:57 p.m.)
> 
> 
> Review request for KDE Edu and Aleix Pol Gonzalez.
> 
> 
> Repository: step
> 
> 
> Description
> -------
> 
> Everything builds and runs after porting to KF5
> 
> 
> Diffs
> -----
> 
>   stepcore/object.cc fbbb9b3 
>   stepcore/types.h b1259a6 
>   stepcore/CMakeLists.txt bb6e584 
>   step/worldmodel.cc 7051905 
>   step/worldscene.cc 5f25a6a 
>   step/toolgraphics.cc 8367eab 
>   step/mainwindow.cc cb3d575 
>   step/propertiesbrowser.cc 9064cba 
>   step/main.cc 1e02dd4 
>   step/mainwindow.h 5e46245 
>   step/infobrowser.cc f5e0004 
>   step/icons/actions/CMakeLists.txt a755344 
>   step/gaskdialog.cc PRE-CREATION 
>   step/icons/CMakeLists.txt fc5acc6 
>   step/gaskdialog.h PRE-CREATION 
>   step/gasgraphics.cc 5005592 
>   step/clipboard.cc 19aa48c 
>   step/gasgraphics.h d4e241c 
>   step/choicesmodel.cc PRE-CREATION 
>   step/CMakeLists.txt 03d9f75 
>   step/choicesmodel.h PRE-CREATION 
>   doc/CMakeLists.txt ee4796c 
>   CMakeLists.txt bf53def 
> 
> Diff: https://git.reviewboard.kde.org/r/118349/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pepe Osca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140527/8bbc0ca9/attachment-0001.html>