Review Request 117917: Fixes crashes when exporting the worksheet as LaTeX

[Alexander Rieder]

> On May 11, 2014, 2:01 p.m., Alexander Rieder wrote:
> > the code looks good, and it doesn't crash anymore, so thats definitely a big improvement! I'm still somewhat surprised that this feature could get so broken somehow..
> > Are you still working on bringing back the missing functionality?
> 
> Lucas Hermann Negri wrote:
>     I'm not working on it right now.
>     
>     I think that the latex export feature can be improved, and this requires some decisions to be made. For example, it currently bundles all the images on the worksheet to an archive file, but there is no distinction between plots / included figures and rendered latex expressions (from math mode); should it omit the rendered latex expressions?

Hi,
yes i think that the rendered expressions should be omitted. The way I think this feature should work is that it generates all the files you need to actually run latex on it and render the document. Thus the already rendered formulas do not add any benefit. 
Given the target of "give me something i can run latex on", I'm  also not 100% sure if the images should be left in an archive, be put alongside the .tex file or if everything should be put in a new folder. What do you think?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117917/#review57716
-----------------------------------------------------------


On April 30, 2014, 11:48 p.m., Lucas Hermann Negri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117917/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 11:48 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> The latex export procedure always tried to access a null pointer, so it always resulted in a crash. Also, the user was asked about exporting the images too, but the read value was never used.
> 
> I've fixed the crash, but there is still missing functionality. I've added basic support for exporting the images, since it was ignoring the user option to export images, but it is far from complete since the images are not referenced inside the latex file.
> 
> 
> Diffs
> -----
> 
>   src/latexentry.cpp b3ce962 
>   src/worksheet.cpp 082e116 
> 
> Diff: https://git.reviewboard.kde.org/r/117917/diff/
> 
> 
> Testing
> -------
> 
> Latex export seems to be working with or without exporting images too.
> 
> 
> Thanks,
> 
> Lucas Hermann Negri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140513/e1103b03/attachment.html>