Review Request 117917: Fixes crashes when exporting the worksheet as LaTeX

[Alexander Rieder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117917/#review57716
-----------------------------------------------------------


the code looks good, and it doesn't crash anymore, so thats definitely a big improvement! I'm still somewhat surprised that this feature could get so broken somehow..
Are you still working on bringing back the missing functionality?

- Alexander Rieder


On April 30, 2014, 11:48 p.m., Lucas Hermann Negri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117917/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 11:48 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> The latex export procedure always tried to access a null pointer, so it always resulted in a crash. Also, the user was asked about exporting the images too, but the read value was never used.
> 
> I've fixed the crash, but there is still missing functionality. I've added basic support for exporting the images, since it was ignoring the user option to export images, but it is far from complete since the images are not referenced inside the latex file.
> 
> 
> Diffs
> -----
> 
>   src/latexentry.cpp b3ce962 
>   src/worksheet.cpp 082e116 
> 
> Diff: https://git.reviewboard.kde.org/r/117917/diff/
> 
> 
> Testing
> -------
> 
> Latex export seems to be working with or without exporting images too.
> 
> 
> Thanks,
> 
> Lucas Hermann Negri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140511/fb0f215b/attachment.html>