Review Request 117973: Clear anagram on each iteration before adding characters

Christoph Feck christoph at maxiom.de
Sat May 3 23:26:23 UTC 2014



> On May 3, 2014, 9:48 p.m., Albert Astals Cid wrote:
> > Looks reasonable, the guy has put a newer patch on the bug cheking for the case where the original word only has 1 character, not sure if we want to take that one or just go with this one?

You are right, if the word has less than two characters, it will loop forever. I suggest to commit his version instead of mine.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117973/#review57221
-----------------------------------------------------------


On May 3, 2014, 12:06 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117973/
> -----------------------------------------------------------
> 
> (Updated May 3, 2014, 12:06 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Bugs: 334107
>     http://bugs.kde.org/show_bug.cgi?id=334107
> 
> 
> Repository: kanagram
> 
> 
> Description
> -------
> 
> Clear anagram on each iteration before adding characters.
> 
> 
> Diffs
> -----
> 
>   src/engine/kanagramgame.cpp bd9d61f 
> 
> Diff: https://git.reviewboard.kde.org/r/117973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140503/58290022/attachment.html>


More information about the kde-edu mailing list