Review Request 117878: Implements a luajit backend for Cantor

Lucas Hermann Negri lucashnegri at gmail.com
Sat May 3 00:55:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117878/
-----------------------------------------------------------

(Updated May 3, 2014, 12:55 a.m.)


Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.


Changes
-------

Removed invalid ';' character that may be causing an error on login(). Also protected the calls to kDebug() any errors instead of crashing. 


Repository: cantor


Description
-------

Implements a luajit backend for Cantor. Implements highlighting, completion, and other features (variable explorer is missing).

Is compatible with Lua science/math libraries like numlua[1] and lna[2].

[1]: https://github.com/carvalho/numlua
[2]: https://bitbucket.org/lucashnegri/lna


Diffs (updated)
-----

  cmake/FindLuaJIT.cmake PRE-CREATION 
  icons/hi48-app-luabackend.png PRE-CREATION 
  src/backends/CMakeLists.txt e89d9e6 
  src/backends/lua/CMakeLists.txt PRE-CREATION 
  src/backends/lua/luabackend.cpp PRE-CREATION 
  src/backends/lua/luabackend.desktop PRE-CREATION 
  src/backends/lua/luabackend.h PRE-CREATION 
  src/backends/lua/luabackend.kcfg PRE-CREATION 
  src/backends/lua/luacompletionobject.h PRE-CREATION 
  src/backends/lua/luacompletionobject.cpp PRE-CREATION 
  src/backends/lua/luaexpression.h PRE-CREATION 
  src/backends/lua/luaexpression.cpp PRE-CREATION 
  src/backends/lua/luaextensions.h PRE-CREATION 
  src/backends/lua/luaextensions.cpp PRE-CREATION 
  src/backends/lua/luahelper.h PRE-CREATION 
  src/backends/lua/luahelper.cpp PRE-CREATION 
  src/backends/lua/luahighlighter.h PRE-CREATION 
  src/backends/lua/luahighlighter.cpp PRE-CREATION 
  src/backends/lua/luasession.h PRE-CREATION 
  src/backends/lua/luasession.cpp PRE-CREATION 
  src/backends/lua/settings.kcfgc PRE-CREATION 
  src/backends/lua/settings.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117878/diff/


Testing
-------

Basic testing performed manually. Everything seems to work as expected.


Thanks,

Lucas Hermann Negri

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140503/0b9e32bd/attachment-0001.html>


More information about the kde-edu mailing list