Review Request 116811: Autorun scripts support to Octave backend

[Alexander Rieder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116811/#review54599
-----------------------------------------------------------


Hi, sorry it took me so long to review. Overall the patch looks good and seems to work as expected. I only have one small issue below:


src/backends/octave/octavesession.cpp
<https://git.reviewboard.kde.org/r/116811/#comment38179>

    Is there a reason why do you construct the Expression by hand, instead of using evaluateExpression(cmd,Expression::DeleteOnFinish)? This would also set the finishingBehavior properly so you won't end up leaking memory for this expression.


- Alexander Rieder


On March 15, 2014, 2:22 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116811/
> -----------------------------------------------------------
> 
> (Updated March 15, 2014, 2:22 p.m.)
> 
> 
> Review request for KDE Edu and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Added autorun scripts support to Octave backend
> 
> Hi Alex and kdeedu team, I am developing autorun scripts supports to some backends. This scripts are loaded when Cantor load a backend - it is based on R-backend. It is the support to Octave. I did some tests and it worked very well.
> 
> I would like to request a review in this code to you.
> 
> Thanks.
> 
> 
> Diffs
> -----
> 
>   src/backends/octave/octavebackend.kcfg cea1a89 
>   src/backends/octave/octavesession.cpp ebb156a 
>   src/backends/octave/settings.ui e245632 
> 
> Diff: https://git.reviewboard.kde.org/r/116811/diff/
> 
> 
> Testing
> -------
> 
> Open Octave backend, go to Settings -> Cantor's Settings -> Octave and add some commands.
> Close Cantor and open it again, selecting Octave backend.
> See if the commands were executed.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140330/768a7e01/attachment.html>