Review Request 116632: Maxima renamed psfile to ps_file

[Alexander Rieder]

> On March 9, 2014, 9:41 p.m., Alexander Rieder wrote:
> > looks good, and seems to work fine. Do you know if this will break with old versions of maxima? If not (or only very old ones), you can go ahead and ship it.
> > Do you have commit access?
> 
> Maximiliano Curia wrote:
>     I think that for versions previous to 0ccd41f22f26400abc7569da4b492e90e234d8b8 there is neither psfile nor ps_file keyword, and that the commit that removed the psfile keyword was applied a long time ago (2009 maybe), but I haven't checked the versions released with that commit applied.

ok, that sounds save enough. I think this and your other patches should go into 4.13+. I will probably commit them tomorrow. Thanks for your contributions!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116632/#review52471
-----------------------------------------------------------


On March 6, 2014, 1:32 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116632/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 1:32 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Hi,
> 
> Back in 2009 maxima developers removed the psfile references from the code, and at the end of 2013 re add it, renaming psfile to ps_file with this commit:
> 
> commit 0ccd41f22f26400abc7569da4b492e90e234d8b8
> Author: Jaime Villate <villate at fe.up.pt>
> Date:   Thu Dec 19 16:21:19 2013 +0000
> 
>     Fixes names of plot options and adds some new ones
> 
>     Names of the new plot options and funcitons now follow the convention of spelled out words, separated by underscores, unless a word has just one letter:
>     remove_plot_option(name), gnuplot_postamble, color_bar_tics, grid2d, iterations, label, same_xy, same_xyz, title, xbounds, xvar, xtics, xy_scale, ybounds, ytics, yx_r
> 
>     New options added to save output in SVG, PNG or PDF formats:
>     png_file, pdf_file, svg_file, gnuplot_png_term_command, gnuplot_pdf_term_command and gnuplot_svg_term_command
> 
> This diff simply replaces the psfile occurrences with ps_file.
> 
> 
> Diffs
> -----
> 
>   src/backends/maxima/maximaexpression.cpp db44e3b8e769d14a945f6c843f2d6da36291b843 
> 
> Diff: https://git.reviewboard.kde.org/r/116632/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140316/c08b7d79/attachment.html>