Review Request 111032: Fix empty names in the find dialog.

Albert Astals Cid aacid at kde.org
Wed Mar 12 21:39:30 UTC 2014



> On Jan. 11, 2014, 4:48 p.m., Albert Astals Cid wrote:
> > This does not apply cleanly to master anymore, can you please rebase it?

No answer in two months, so i'm discarding it. If you find time please rebase the patch so that it applies and submit it again.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111032/#review47212
-----------------------------------------------------------


On Jan. 11, 2014, 4:48 p.m., Aneesh Dogra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111032/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2014, 4:48 p.m.)
> 
> 
> Review request for KDE Edu and KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Edit the setNames method of StarObject to expand greek characters in longname and use the longname() method to get the name of the star in starcomponent.cpp.
> 
> This fixes the empty names in the find dialog, gives out better names for entries and uses less code.
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/starcomponent.cpp a44e37a 
>   kstars/skyobjects/starobject.cpp 8976341 
> 
> Diff: https://git.reviewboard.kde.org/r/111032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aneesh Dogra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140312/7d2bdc36/attachment.html>


More information about the kde-edu mailing list