Review Request 116638: Migrate to eigen3

[Etienne Rebetez]

> On March 6, 2014, 5:15 p.m., Aleix Pol Gonzalez wrote:
> > No changes are required in the C++ code?
> 
> Maximiliano Curia wrote:
>     Yeah, that's weird. Oh, I see, the eigen is not even used by kalzium directly, libavogadro requires it, but it doesn't even link against it, so I guess it's all types, definitions and inline functions.
> 
> Aleix Pol Gonzalez wrote:
>     Fair enough, let's do this. I'll give the shipit because there doesn't seem to be any Kalzium maintainers around.
> 
> Maximiliano Curia wrote:
>     Ok by me, but apparently avogadro can use either eigen2 or eigen3 and prefers eigen2, that's as far as I understand: https://github.com/cryos/avogadro/commit/3cc14da0f92e6ea0bd763e97b5711c4afe56a7cd
>     It would be great if kalzium could follow avogadro preferences, maybe we need to ping Marcus D. Hanwell <marcus.hanwell at kitware.com> about this, we might get a nicer patch from it.
>     
>     Also, I don't have developers access, so, I'll need you to commit the change if you consider it a good idea.
>     Sorry about the mess, I'm just trying to reduce the amount of patches in the debian packages.

Thanks a lot:)
I can commit the patch. I'll do that in the next days.


- Etienne


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116638/#review52281
-----------------------------------------------------------


On March 6, 2014, 3:12 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116638/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 3:12 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Hi,
> 
> Eigen2 was dropped from the debian archive, so Anton Gladky adapted kalzium to use eigen3, that can be followed in http://bugs.debian.org/728324
> 
> Please consider the inclusion of this change.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d7583c32b6497972ce42534423b5f07244fb93f0 
>   KalziumConfigureChecks.cmake 8917d5e95e05150002d01f09955fa405879a8ac4 
>   cmake/modules/FindEigen3.cmake PRE-CREATION 
>   compoundviewer/CMakeLists.txt b2b7e6c6e1b617ab464389266fe83c16748b168d 
>   src/CMakeLists.txt 0ada32e60ea66ec5577170574c50d335c8c25f4c 
> 
> Diff: https://git.reviewboard.kde.org/r/116638/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140310/1f3ff028/attachment.html>