Review Request 116660: Implement fixed sessions for Parley

[Frederik Gladhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116660/#review52402
-----------------------------------------------------------


I like the direction this is going. I'm personally not a huge fan of the naming fixed/continous, but I don't have a much better suggestion right now either.


src/configure-practice/thresholdoptions.cpp
<https://git.reviewboard.kde.org/r/116660/#comment37080>

    If this include is no longer needed, why not just remove it.


- Frederik Gladhorn


On March 8, 2014, 4:44 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116660/
> -----------------------------------------------------------
> 
> (Updated March 8, 2014, 4:44 p.m.)
> 
> 
> Review request for KDE Edu and Amarvir Singh.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This patch implement fixed sessions for Parley.  With that I mean that training is split up into sessions with a fixed number maximum number of words. The default value for the number is 20 but it could also be fewer. At most 5 of those can be new words, so it also makes it easier to learn new vocabulary by not allowing an unwieldy number of new words at a time. Before this patch a session was all the words that were due based on time since last practice and grade, which meant that a session could potentially consist of thousands of words.
> 
> Technically this patch works by splitting the old SessionManager into a base class (SessionManagerBase) and a specific class (SessionManagerContinuous) and then implementing a new class SessionManagerFixed.  The SessionManager was recently renamed into that name from the old TestEntryManager which didn't describe what it did at all.
> 
> This is the first milestone in the project to create a new session system.  Step 2 will be with adding some configuration and step 3 will be a new graphic look.
> 
> Note that in this version of the patch the numbers 20 (max size) and 5 (max new words) are replaced with 7 and 3 to make testing easier.
> 
> 
> Diffs
> -----
> 
>   src/settings/languagepropertiespage.cpp e324167 
>   src/practice/writtenpracticevalidator.h d38190e 
>   src/practice/writtenbackendmode.cpp 4cb723e 
>   src/practice/sessionmanagerfixed.cpp PRE-CREATION 
>   src/practice/writtenbackendmode.h dd8d3ee 
>   src/practice/sessionmanagerfixed.h PRE-CREATION 
>   src/practice/sessionmanagercontinuous.cpp PRE-CREATION 
>   src/practice/sessionmanagercontinuous.h PRE-CREATION 
>   src/practice/sessionmanagerbase.cpp PRE-CREATION 
>   src/practice/sessionmanagerbase.h PRE-CREATION 
>   src/practice/sessionmanager.cpp adea30b 
>   TODO-SESSIONS PRE-CREATION 
>   src/CMakeLists.txt 03d05ee 
>   src/configure-practice/blockoptions.h 1882994 
>   src/configure-practice/thresholdoptions.cpp 1fb55e1 
>   src/parleymainwindow.h 318312c 
>   src/parleymainwindow.cpp 1672647 
>   src/practice/DESIGN 99d4c0b 
>   src/practice/comparisonbackendmode.h e5cb5d0 
>   src/practice/comparisonbackendmode.cpp a3efac8 
>   src/practice/conjugationbackendmode.h 8cc59ee 
>   src/practice/conjugationbackendmode.cpp fa365d9 
>   src/practice/examplesentencebackendmode.h 38941e1 
>   src/practice/examplesentencebackendmode.cpp 0cc812c 
>   src/practice/genderbackendmode.h 9a4a28a 
>   src/practice/genderbackendmode.cpp b2cc7c1 
>   src/practice/multiplechoicebackendmode.h a77265e 
>   src/practice/multiplechoicebackendmode.cpp 51f35a3 
>   src/practice/practicemainwindow.h 93fcd66 
>   src/practice/practicemainwindow.cpp 6fe7aa1 
>   src/practice/practicestatemachine.h 81cff91 
>   src/practice/practicestatemachine.cpp 16f86c1 
>   src/practice/practicesummarycomponent.h 41cc83b 
>   src/practice/practicesummarycomponent.cpp bffb584 
>   src/practice/sessionmanager.h 64e70c9 
> 
> Diff: https://git.reviewboard.kde.org/r/116660/diff/
> 
> 
> Testing
> -------
> 
> Tested with a special version of a word list I am working with.  I will attach it here.
> 
> 
> File Attachments
> ----------------
> 
> A small test file
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/08/f5213df1-cfe8-44cc-9d16-c2956bf39076__Thai-numbers-copy.kvtml
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140308/6093e0e1/attachment-0001.html>