Review Request 116576: [Patch][Parley] Fixes the legend in the statistics.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116576/#review51818
-----------------------------------------------------------

Ship it!


Looks good except for the many hardcoded figures.  If possible fix those and then you can push.


src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/116576/#comment36876>

    Not sure I like this many magic numbers.  Can they be given logical names?
    
    Same for the next 3-4 lines which are not part of this patch...


- Inge Wallin


On March 3, 2014, 7:43 p.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116576/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 7:43 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Adds white color to last grade box and changes the height of the header.
> 
> 
> Diffs
> -----
> 
>   src/statistics/lessonstatistics.cpp 16d1836 
> 
> Diff: https://git.reviewboard.kde.org/r/116576/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140303/91af7818/attachment.html>