Review Request 116095: Loading images with Parley Google images plugin's in-built screen scraper fails - using Google JSON AJAX API instead

[Amarvir Singh]

> On March 1, 2014, 6:56 p.m., Yuri Chornoivan wrote:
> > Works fine here. Please remove "usr/share/kde4/apps/parley/" from the path to the patched file. Many thanks for your work.
> 
> Amarvir Singh wrote:
>     btw Yuri, would simplejson be adding another dependency? It isn't a part of standard python, I suppose, is it?
> 
> Yuri Chornoivan wrote:
>     It is a part of mwclient, which is a part of Parley itself now.

Good to know :) Just wanted to make sure it doesn't add any new dependency, so that it could be added to 4.13 branch too.


- Amarvir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116095/#review51431
-----------------------------------------------------------


On March 1, 2014, 7:19 p.m., Maximilian Reiner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116095/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 7:19 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Parley Google images plugin fails loading images with in-built screen scraper.
> Simple RESTful image search with Google's API seems to be more preferable to do this. 
> 
> 
> Diffs
> -----
> 
>   plugins/google_images.py 22b72d6 
> 
> Diff: https://git.reviewboard.kde.org/r/116095/diff/
> 
> 
> Testing
> -------
> 
> Loading images with Google JSON AJAX API succeeded. 
> 
> 
> Thanks,
> 
> Maximilian Reiner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140301/1857f0b5/attachment.html>