Review Request 118959: Fix linking to ncurses

[Aleix Pol Gonzalez]

> On June 26, 2014, 11:15 p.m., Aleix Pol Gonzalez wrote:
> > calgebra/CMakeLists.txt, line 7
> > <https://git.reviewboard.kde.org/r/118959/diff/2/?file=284881#file284881line7>
> >
> >     Can we move that check to FindReadline.cmake?
> 
> Vadim Zhukov wrote:
>     This will force FindReadline.cmake contain a call to find_package(Curses), making FindReadline.cmake much more complicated (will need to handle *_QUIET, etc.). But if you'll request that, I'll do.

Meh, it's fine, there's probably better things to spend time on.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118959/#review61059
-----------------------------------------------------------


On June 27, 2014, 12:16 a.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118959/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 12:16 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> On some systems, libreadline is linked to Curses implementation directly; on other, it's not, requiring you to link both Curses and Readline libraries manually.
> 
> Also, OpenBSD ships with old libreadline that lacks free_history_entry().
> 
> I've added all required checks, and forced linking to NCurses library, too.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 09e216f 
>   calgebra/CMakeLists.txt 1cbb06b 
>   calgebra/main.cpp fa045ed 
> 
> Diff: https://git.reviewboard.kde.org/r/118959/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140627/a1128fd2/attachment.html>