[kig] /: Make SegmentAxisType Equivalent to the Previous Macro
David Narvaez
david.narvaez at computer.org
Wed Jun 25 16:32:08 UTC 2014
On Tue, Jun 24, 2014 at 1:57 PM, David E. Narvaez
<david.narvaez at computer.org> wrote:
> Git commit 494629177ae9360ffd33fd84ae12403f20b920db by David E. Narvaez.
> Committed on 24/06/2014 at 17:55.
> Pushed by narvaez into branch 'master'.
>
> Make SegmentAxisType Equivalent to the Previous Macro
>
> As pointed out in https://git.reviewboard.kde.org/r/118785/, the new
> SegmentAxisABType took two arguments instead of one like the old macro,
> so this fixes compatibility with the previous behavior.
Aniket,
As you pointed out in the private e-mail, the final goal is to have a
way to be able to create a perpendicular bisector from either a
segment or two points, but the feature freeze for KDE 4.14 is today[0]
so I decided to commit the least intrusive patch that honors the old
behavior and leave the rest of the design and implementation to you
since you will know better how this will interact with the
constructions in Geogebra.
In terms of design, I would expect a Segment Axis object to deal with
segments, not with two points, so I would think of a separate object
called Symmetry Axis or something like that (I'm terrible with names
so if anybody has a better idea please chime in) and a separate icon
that we can group with Segment Axis like we group the conics. The
implementation would essentially be your previous work on
SegmentAxisABType.
You can continue your work on this implementation in the geogebra
branch, since it would be mostly independent from what we have in
master now.
David E. Narvaez
[0] http://techbase.kde.org/Schedules/KDE4/4.14_Release_Schedule
More information about the kde-edu
mailing list