Review Request 118924: Port from KGlobal::locale() to QLocale().

Jeremy Whiting jpwhiting at kde.org
Wed Jun 25 02:20:59 UTC 2014



> On June 24, 2014, 8:16 p.m., Aleix Pol Gonzalez wrote:
> > keduvocdocument/keduvockvtmlreader.cpp, line 1071
> > <https://git.reviewboard.kde.org/r/118924/diff/2/?file=284503#file284503line1071>
> >
> >     I have n oclue of what "locale" is in this context... The thing is that our locale names used to be e.g. "ca" where now we have "es_CA".

In terms of kvtml files we sort files into subfolders based on the language, not locale. QLocale will take es_CA and give it a language of spanish and QLocale::languageToString(language) will then give "Spanish" on an english computer/locale, and "Espanol" or whatnot when the system locale is es I guess.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118924/#review60921
-----------------------------------------------------------


On June 24, 2014, 6:46 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118924/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 6:46 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.
> 
> 
> Repository: libkdeedu
> 
> 
> Description
> -------
> 
> Port from KGlobal::locale() to QLocale().
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvockvtmlreader.cpp 3b50a963ded05960b54372b71a4339018ab2c383 
> 
> Diff: https://git.reviewboard.kde.org/r/118924/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140625/0cd4215e/attachment.html>


More information about the kde-edu mailing list