Review Request 118826: Added statistics display of second language trained in multi-way training.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118826/#review60782
-----------------------------------------------------------


The feature works well on a user level even if we may have to fine tune the visual appearance a little.  But see the issue outlined below in the code.  That has to be fixed before merging.


src/vocabulary/containermodel.h
<https://git.reviewboard.kde.org/r/118826/#comment42361>

    It is not acceptable to define this enum in 3 places.  This seems to be the logical choice. All the others have to use this one by includeing this .h file.


- Inge Wallin


On June 19, 2014, 7:54 a.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118826/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 7:54 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Added statistics to report on both languages when training two way, to get the feature in before the freeze.
> 
> 1. Added enum to define the statistics column names.
> 2. Added switch statements on practiceDirection to determine the column to display and the language to display in it.
> 
> New Problems: 
> 1. Changing the practice Direction doesn't update the display until you leave the screen and then return.
> 2. The header is only expecting a single column of day so the legend only spans the last column.
> 
> 
> Diffs
> -----
> 
>   src/statistics/lessonstatistics.h 42597c6 
>   src/statistics/lessonstatistics.cpp 756d96a 
>   src/statistics/statisticsmainwindow.h fe8872c 
>   src/statistics/statisticsmainwindow.cpp ccf7f0a 
>   src/statistics/statisticsmodel.cpp e195778 
>   src/vocabulary/containermodel.h 32771b5 
>   src/vocabulary/containermodel.cpp d8f0b00 
> 
> Diff: https://git.reviewboard.kde.org/r/118826/diff/
> 
> 
> Testing
> -------
> 
> Played multiplechoice forwards, backwards and two way.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140623/6d3c046b/attachment-0001.html>