Review Request 118595: Fixes the evaluation of worksheets with latex entries, fixing the list traversal.

Alexander Rieder alexanderrieder at gmail.com
Sun Jun 22 13:43:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118595/#review60704
-----------------------------------------------------------

Ship it!


fixes the bug and makes the code much more readable. good work! please backport to 4.13!

- Alexander Rieder


On June 6, 2014, 2:10 p.m., Lucas Hermann Negri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118595/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 2:10 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Bugs: 334769
>     http://bugs.kde.org/show_bug.cgi?id=334769
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Fixed a bug where the evaluation of a worksheet would stop on the first LaTeX entry (fixes bug 334769).
> This patch depends on the last patch that fixed latex export on latex entries. 
> 
> 
> Diffs
> -----
> 
>   src/latexentry.cpp b3ce962 
> 
> Diff: https://git.reviewboard.kde.org/r/118595/diff/
> 
> 
> Testing
> -------
> 
> A worksheet that previously would not be evaluated was correctly evaluated after the changes.
> 
> 
> Thanks,
> 
> Lucas Hermann Negri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140622/1811f94b/attachment-0001.html>


More information about the kde-edu mailing list