Review Request 118611: Add Ctrl+Space as alternative code completion command in Cantor worksheet

[Filipe Saraiva]

> On June 8, 2014, 9:28 a.m., Alexander Rieder wrote:
> > I think this is the wrong place for this change. As far as I remember this code is only there to free up tab for KActions. Could you look for the respective kaction(somewhere in worksheet or the part I guess) and set the default there? (This keeps things consistent with what you change from the gui option)
> 
> Filipe Saraiva wrote:
>     Hi Alex, thanks for your review. I uploaded a new patch and I think it is correct now. Please, let me know if it is ok. I will discard the patch 1.

ping ;)


- Filipe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118611/#review59543
-----------------------------------------------------------


On June 8, 2014, 6:32 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118611/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 6:32 p.m.)
> 
> 
> Review request for KDE Edu and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Cantor have a new code completion feature in script editor [http://blog.filipesaraiva.info/?p=1275]. This code completion is activated typing Ctrl+Space. But in Cantor worksheet the code completion is activated typing TAB key.
> 
> This patch add Ctrl+Space as a command to activate code completion in Cantor worksheet. Then Cantor worksheet will have two default command to this feature: TAB key (for historical reasons) and Ctrl+Space.
> 
> 
> Diffs
> -----
> 
>   src/cantor_part.cpp eda5fd6 
> 
> Diff: https://git.reviewboard.kde.org/r/118611/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140621/530dd946/attachment.html>