Review Request 118825: FEATURE: Upgrade averageGrade to account for preGrade levels.

Inge Wallin inge at lysator.liu.se
Thu Jun 19 10:28:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118825/#review60491
-----------------------------------------------------------

Ship it!


Looks good except the nitpick below.  But you since you don't have any commit account you don't have to do anything.  I'll fix the spaces, commit and push.  Good catch!


keduvocdocument/keduvoccontainer.cpp
<https://git.reviewboard.kde.org/r/118825/#comment42243>

    minor formatting: we use spaces around operators


- Inge Wallin


On June 19, 2014, 7:53 a.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118825/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 7:53 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: libkdeedu
> 
> 
> Description
> -------
> 
> Changed averageGrade to account for preGrade levels as a set of micro levels worth 1/KV_MAX_GRADE^2 inside the lowest grade box.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvoccontainer.cpp ded5410 
> 
> Diff: https://git.reviewboard.kde.org/r/118825/diff/
> 
> 
> Testing
> -------
> 
> Played multiple-choice forwards, backwards and two way.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140619/8088ff4b/attachment.html>


More information about the kde-edu mailing list